-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add derive serde
attributes to the generated message and service struct
#137
Conversation
Will this cause build failure if you try to serialize a fixed length array longer than 32? |
The const generics function will be stable in version 1.51, and this defect may be improved in the future. I still close the pr first. |
Yeah once the feature is there, and serde implements it, adding serde support will be extremely simple, and I'd likely add it directly without any feature flags. |
ok |
@adnanademovic @ZhangHanDong |
@KrasnovPavel It still doesn't |
In the meantime, I've added https://github.com/adnanademovic/rosrust/blob/master/rosrust/tests/dynamic_msg.rs#L100-L144 You can do |
hi @adnanademovic ,
thanks very much for your contribution ,
rosrust
is a great crate.I recently plan to use it in production environment, but I need to return
json
string directly from the generated struct. But now ,rosrust
doesn't support this feature, so I implemented it by myself, and test available in the actual environment.I found that someone else has submitted the PR #135 of similar feature, but his is wrong and can't be compiled.
I hope you can merge and release a new crate version so that my project can use the new version instand of relying on git.
thanks !
usage: